sampling: introduce event processor #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
axw
force-pushed
the
tbs-processor
branch
4 times, most recently
from
3529d05 to
f6401c3
Compare
simitt
approved these changes
Oct 7, 2020
| if err == errTooManyTraceGroups { | ||
| // Too many trace groups, drop the transaction. | ||
| // | ||
| // TODO(axw) log a warning with a rate limit. |
|
nothing to be tested here manually as the processor is not used yet. |
axw
added a commit
to axw/apm-server
that referenced
this pull request
Nov 18, 2020
* sampling: introduce processor
axw
added a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Implement a tail-based sampling event processor.
The processor passes root transactions through a reservoir sampler, and periodically "finalizes" the reservoirs to make local sampling decisions. The resulting sampled trace events are then indexed into Elasticsearch; sampled trace IDs are published for other APM Servers to index related events.
To be done in follow-ups:
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
make testRelated issues
Part of #4185