Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] sampling: add trace group sampling reservoirs (#4182) #4216

Merged
merged 1 commit into from
Sep 18, 2020
Merged

[7.x] sampling: add trace group sampling reservoirs (#4182) #4216

merged 1 commit into from
Sep 18, 2020

Conversation

axw
Copy link
Member

@axw axw commented Sep 18, 2020

Backports the following commits to 7.x:

@axw
sampling: add trace group sampling reservoirs (elastic#4182)
1a84b11 
* sampling: add trace group sampling reservoirs

Introduce a type for maintaining a collection of trace groups.

For each trace group we measure the observed ingest rate for
the trace group (number of root traces per sampling interval),
and maintain a weighted random sampling reservoir for recording
trace IDs. Trace IDs are weighted by root transaction duration,
which means slower traces will have a greater chance of being
captured.

* Address self-review comments

- better name for decay factor
- fix doc comments to reflect reality
- fix criteria for removing trace groups

* Update x-pack/apm-server/sampling/groups.go

* Remove unnecessary variable assignment
@axw axw added the backport label Sep 18, 2020
@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4216 opened]

  • Start Time: 2020-09-18T05:52:02.260+0000

  • Duration: 29 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 3087
Skipped 142
Total 3229

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-18T06:06:59.580+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-18T06:20:33.835+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 50 sec

    • Start Time: 2020-09-18T06:01:19.817+0000

    • log

@axw axw merged commit 4095bdd into elastic:7.x Sep 18, 2020
@axw axw deleted the backport/7.x/pr-4182 branch September 18, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axw @apmmachine