Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Index page URL and Referer as ECS fields (#3857) #3865

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Jun 10, 2020

Backports the following commits to 7.x:

* Split Page URL into ECS parts and store it separately

* Store page referer separately as ECS field

* Update changelog
@jalvz jalvz added the backport label Jun 10, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #3865 into 7.x will decrease coverage by 0.04%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##              7.x    #3865      +/-   ##
==========================================
- Coverage   79.95%   79.91%   -0.05%     
==========================================
  Files         137      137              
  Lines        6182     6199      +17     
==========================================
+ Hits         4943     4954      +11     
- Misses       1239     1245       +6     
Impacted Files Coverage Δ
model/context.go 78.99% <66.66%> (-5.72%) ⬇️
model/error.go 98.75% <100.00%> (+0.04%) ⬆️
model/modeldecoder/context.go 94.32% <100.00%> (+0.04%) ⬆️
model/modeldecoder/error.go 85.05% <100.00%> (ø)
model/modeldecoder/transaction.go 51.06% <100.00%> (ø)
model/transaction.go 100.00% <100.00%> (ø)
processor/otel/consumer.go 95.35% <100.00%> (+2.42%) ⬆️
kibana/connecting_client.go 64.51% <0.00%> (-8.07%) ⬇️

* Update approval files

* make update

* more approval files
@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #3865 updated]

  • Start Time: 2020-06-11T07:27:05.812+0000

  • Duration: 26 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 3026
Skipped 142
Total 3168

Steps errors

Expand to view the steps failures

  • Name: Test Sync
    • Description: ./script/jenkins/sync.sh

    • Duration: 2 min 27 sec

    • Start Time: 2020-06-11T07:37:18.087+0000

    • log

@jalvz jalvz merged commit e17593a into elastic:7.x Jun 11, 2020
@axw
Copy link
Member

axw commented Jul 21, 2020

Verified with BC2. Created a barebones webpage instrumented with RUM:

<html>
<head>
<script src="https://unpkg.com/@elastic/apm-rum/dist/bundles/elastic-apm-rum.umd.min.js" crossorigin></script>
<script>
elasticApm.init({
  serviceName: 'webapp',
  serverUrl: 'http://localhost:8200'
})
</script>
</head>
<body>
hello!
<a href="/">back</a>
</body>

Clicking the button takes you to the same page with referer set. Confirmed that transaction.page.url is exploded into url.*, and transaction.page.referer is copied to http.request.referrer.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants