Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to elastic/beats@d5fee98f724b #3847

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Update to elastic/beats@d5fee98f724b #3847

merged 5 commits into from
Jun 5, 2020

Conversation

axw
Copy link
Member

@axw axw commented Jun 5, 2020

Motivation/summary

Update to elastic/beats@d5fee98f724b, to bring in elastic/beats@7927da7 and fix hey-apm/CI.

Drive-by enhancements to Makefile:

  • update the suggested commit/PR title to use elastic/beats@sha, to get clickable links in GitHub
  • check that .go-version is in sync with beats

Checklist

I have considered changes for:
- [ ] documentation
- [ ] logging (add log lines, choose appropriate log selector, etc.)
- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)

How to test these changes

make update-beats

Related issues

Closes #3846

axw added 3 commits June 5, 2020 13:48
Use the format elastic/beats@commit, so we can
easily link through to the commit to inspect.
@axw axw requested a review from a team June 5, 2020 06:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #3847 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3847   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files         135      135           
  Lines        6142     6142           
=======================================
  Hits         4892     4892           
  Misses       1250     1250           

@apmmachine
Copy link
Contributor

apmmachine commented Jun 5, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #3847 updated]

  • Start Time: 2020-06-05T07:33:50.974+0000

  • Duration: 47 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 3201
Skipped 146
Total 3347

Makefile Show resolved Hide resolved
@axw axw changed the title Update to elastic/beats@7b9c535b4a0b Update to elastic/beats@d5fee98f724b Jun 5, 2020
@axw axw merged commit facd5a2 into elastic:master Jun 5, 2020
@axw axw deleted the update-beats branch June 5, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make: update-beats should check that our Go version is in sync
4 participants