Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM V3] Correctly process tags in RUMV3 metricsets. #3816

Merged
merged 1 commit into from
May 26, 2020

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented May 25, 2020

Also, add missing fields for approval tests.

Motivation/summary

Adds to the rum v3 sample document any missing fields. Doing this, I found out that tags in metricsets were not abbreviated.
It is not too bad because RUM doesn't use them yet, but it is fixed here.

Checklist

I have considered changes for:

How to test these changes

Related issues

closes #3476

Also, add missing fields for approval tests.
@jalvz jalvz requested a review from a team May 25, 2020 12:32
@codecov-commenter
Copy link

Codecov Report

Merging #3816 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3816      +/-   ##
==========================================
+ Coverage   79.81%   79.89%   +0.08%     
==========================================
  Files         136      136              
  Lines        6158     6158              
==========================================
+ Hits         4915     4920       +5     
+ Misses       1243     1238       -5     
Impacted Files Coverage Δ
model/modeldecoder/metricset.go 83.33% <100.00%> (ø)
kibana/connecting_client.go 72.58% <0.00%> (+8.06%) ⬆️

@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #3816 opened]

  • Start Time: 2020-05-25T12:32:05.275+0000

  • Duration: 45 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 3227
Skipped 145
Total 3372

Steps errors

Expand to view the steps failures

  • Name: Test Sync
    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 53 sec

    • Start Time: 2020-05-25T12:42:02.144+0000

    • log

@jalvz jalvz merged commit 3c795c2 into elastic:master May 26, 2020
jalvz added a commit to jalvz/apm-server that referenced this pull request May 26, 2020
Also, add missing fields for approval tests.
jalvz added a commit to jalvz/apm-server that referenced this pull request May 26, 2020
Also, add missing fields for approval tests.
jalvz added a commit that referenced this pull request May 26, 2020
Also, add missing fields for approval tests.
jalvz added a commit that referenced this pull request May 26, 2020
Also, add missing fields for approval tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RUM v3] Full golden test coverage
4 participants