Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.8] go es #3780

Merged
merged 2 commits into from
May 12, 2020
Merged

[7.8] go es #3780

merged 2 commits into from
May 12, 2020

Conversation

simitt
Copy link
Contributor

@simitt simitt commented May 11, 2020

Motivation/summary

Update the go-elasticsearch dependency to the 7.8 branch.

Checklist

- [ ] I have signed the Contributor License Agreement.
- [ ] I have updated CHANGELOG.asciidoc

I have considered changes for:

How to test these changes

make test

@simitt simitt added the v7.8.0 label May 11, 2020
@apmmachine
Copy link
Contributor

apmmachine commented May 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-05-12T11:49:58.333+0000

  • Duration: 28 min 36 sec (1655917)

Test stats 🧪

Test Results
Failed 0
Passed 3008
Skipped 142
Total 3150

@simitt
Copy link
Contributor Author

simitt commented May 11, 2020

failing docs test seems unrelated

@codecov-io
Copy link

Codecov Report

Merging #3780 into 7.8 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              7.8    #3780   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files         136      136           
  Lines        6152     6152           
=======================================
  Hits         4910     4910           
  Misses       1242     1242           

@simitt simitt merged commit fa08ad1 into elastic:7.8 May 12, 2020
@axw axw self-assigned this May 14, 2020
@axw
Copy link
Member

axw commented May 14, 2020

Confirmed with ngrep -q "go-elasticsearch", running apm-server apikey info --name=foo triggering a query:

GET /_security/api_key?name=foo HTTP/1.1..Host: elasticsearch:9200..User-Agent: go-elasticsearch
/7.8.0 (linux amd64; Go 1.13.9)..Authorization: Basic YWRtaW46Y2hhbmdlbWU=..Accept- 
Encoding: gzip....

@simitt simitt deleted the 7.8-update-go-es branch May 27, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants