model: enhancements to support transaction aggregations #3639
Conversation
Eport the System.Metadata (was System.hostname) method, which will be used for grouping in the upcoming histogram aggregator.
Change model/metricset to use non-pointer fields, and adapt modeldecoder to the changes.
Changes to support transaction duration histograms.
- Add transaction.{root,result} fields.
- Add support for histogram metrics. This is currently
only supported in the model type, and not in the
intake API, as we lack a nice means of dynamic field
mapping for histograms.
| i++ | ||
| valueFieldName := fieldName("value") | ||
| for name, s := range input { | ||
| sampleObj, _ := s.(map[string]interface{}) |
There was a problem hiding this comment.
Why are you removing the error check here?
There was a problem hiding this comment.
It's guaranteed to be that type, by virtue of having passed JSON Schema validation. Since I moved schema validation into the exported Decode methods, you can no longer get here without passing validation.
|
|
||
| // Counts holds the bucket counts for histogram metrics. | ||
| // | ||
| // These numbers must be positive or zero. |
There was a problem hiding this comment.
(Where) do you plan to add checks for the restrictions mentioned in the comments?
There was a problem hiding this comment.
I wasn't planning on adding any checks beyond what Elasticsearch does, I just added that as a reminder/documentation.
There was a problem hiding this comment.
In case it's not clear: if/when we add support for histogram metrics coming from agents, we would validate these constraints in modeldecoder. In the immediate future these fields will only be set by the metrics computed by the server, so we'll be in full control of the data.
* model/metadata: export System.Hostname method
Export the System.Metadata (was System.hostname) method,
which will be used for grouping in the upcoming histogram
aggregator.
* model/metricset: non-pointer field types
Change model/metricset to use non-pointer fields,
and adapt modeldecoder to the changes.
* model/metricset: add new metricset fields
Changes to support transaction duration histograms.
- Add transaction.{root,result} fields.
- Add support for histogram metrics. This is currently
only supported in the model type, and not in the
intake API, as we lack a nice means of dynamic field
mapping for histograms.
* beater/config: fix some 'go vet' errors
* model/metadata: export System.Hostname method
Export the System.Metadata (was System.hostname) method,
which will be used for grouping in the upcoming histogram
aggregator.
* model/metricset: non-pointer field types
Change model/metricset to use non-pointer fields,
and adapt modeldecoder to the changes.
* model/metricset: add new metricset fields
Changes to support transaction duration histograms.
- Add transaction.{root,result} fields.
- Add support for histogram metrics. This is currently
only supported in the model type, and not in the
intake API, as we lack a nice means of dynamic field
mapping for histograms.
* beater/config: fix some 'go vet' errors
Motivation/summary
There are a few smallish changes here bundled together, in support of transaction duration aggregations (#3485).
Summary:
metadata.System.Hostname, so its value can be used in aggregation keysmetricset.Transaction.{Result,Root}fields, to use in aggregation keysmetricset.Sample.{Counts,Values}fields, for indexing histogram metricsmetricset.Metricsetand related types to simplify usage, and reduce allocationsNote that the added fields are only added to the model types, and not the intake API. That will come later, as part of #3195.
Checklist
make check-fullfor static code checks and linting)- [ ] I have made corresponding changes to the documentation- [ ] I have updated CHANGELOG.asciidocHow to test these changes
make testRelated issues
#3485