Retry connection when Kibana version is not compatible. #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3031 +/- ##
==========================================
- Coverage 78.54% 78.44% -0.11%
==========================================
Files 96 96
Lines 4797 4820 +23
==========================================
+ Hits 3768 3781 +13
- Misses 1029 1039 +10
|
|
This is a temporary fix for 7.5.1 |
axw
approved these changes
Dec 12, 2019
kibana/connecting_client.go
Outdated
Comment on lines
112
to
113
| c.m.Lock() | ||
| defer c.m.Unlock() |
There was a problem hiding this comment.
this should probably also be RLock/RUnlock, as c.client is only read
jalvz
force-pushed
the
retry-stale-kibana-conn
branch
from
57beb62 to
b0a4418
Compare
jalvz
added a commit
to jalvz/apm-server
that referenced
this pull request
Dec 12, 2019
* Retry connection when Kibana version is not compatible. Fixes elastic#3022 * Update changelog
jalvz
added a commit
to jalvz/apm-server
that referenced
this pull request
Dec 12, 2019
* Retry connection when Kibana version is not compatible. Fixes elastic#3022 * Update changelog
jalvz
added a commit
that referenced
this pull request
Dec 12, 2019
simitt
pushed a commit
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3022