Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service.node.configured_name to Intake API and transform into service.node.name for ES #2746

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Sep 30, 2019

Add service.node.configured_name to Intake API and add support for
retrieving and indexing service.node.name in ES.

fixes #2696

@simitt simitt force-pushed the 2696-service.node.configured-name branch from 0e0083c to 06ca4f2 Compare October 2, 2019 09:19
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #2746 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2746      +/-   ##
==========================================
+ Coverage   78.78%   78.79%   +<.01%     
==========================================
  Files          83       82       -1     
  Lines        4430     4300     -130     
==========================================
- Hits         3490     3388     -102     
+ Misses        940      912      -28
Impacted Files Coverage Δ
model/span/event.go 86.95% <ø> (ø) ⬆️
model/transaction/event.go 95.18% <100%> (ø) ⬆️
model/metadata/service.go 89.74% <100%> (+1.86%) ⬆️
model/metadata/metadata.go 96.07% <100%> (+0.52%) ⬆️
model/error/event.go 97.42% <100%> (ø) ⬆️
agentcfg/model.go 91.3% <0%> (-2.45%) ⬇️
agentcfg/fetch.go 87.87% <0%> (-2.13%) ⬇️
agentcfg/cache.go 96.42% <0%> (-0.72%) ⬇️
beater/api/mux.go 70.96% <0%> (-0.47%) ⬇️
beater/middleware/cors_middleware.go 100% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda0fce...541f3d9. Read the comment docs.

Add service.node.configured_name to Intake API and add support for
retrieving and indexing service.node.name in ES.

fixes elastic#2696
@simitt simitt force-pushed the 2696-service.node.configured-name branch from 06ca4f2 to 5828ad2 Compare October 2, 2019 09:40
@simitt simitt changed the title Add support for service.node.name Add service.node.configured_name to Intake API and transform into service.node.name for ES Oct 2, 2019
@simitt simitt requested a review from jalvz October 2, 2019 09:42
@simitt simitt marked this pull request as ready for review October 2, 2019 09:42
@simitt simitt added the review label Oct 2, 2019
model/metadata/metadata.go Outdated Show resolved Hide resolved
@simitt simitt merged commit e8af25a into elastic:master Oct 2, 2019
simitt added a commit to simitt/apm-server that referenced this pull request Oct 9, 2019
…vice.node.name for ES (elastic#2746)

Add service.node.configured_name to Intake API and add support for retrieving and indexing service.node.name in ES.

fixes elastic#2696
@simitt simitt deleted the 2696-service.node.configured-name branch October 11, 2019 14:48
simitt added a commit to simitt/kibana that referenced this pull request Oct 14, 2019
simitt added a commit to elastic/kibana that referenced this pull request Oct 14, 2019
simitt added a commit to elastic/kibana that referenced this pull request Oct 14, 2019
simitt added a commit that referenced this pull request Oct 14, 2019
…vice.node.name for ES (#2746) (#2787)

Add service.node.configured_name to Intake API and add support for retrieving and indexing service.node.name in ES.

fixes #2696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new service field to Intake API + ES
3 participants