Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc clarifications #2032

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Doc clarifications #2032

merged 2 commits into from
Mar 22, 2019

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Mar 20, 2019

fixes #2016

also part of #2026

_meta/beat.yml Outdated
@@ -188,7 +188,7 @@ apm-server:
#setup.template.name: "apm-%{[observer.version]}"

# Template pattern. By default the template pattern is "apm-%{[observer.version]}-*" to apply to the default index settings.
# The first part is the version of the beat and then -* is used to match all daily indices.
# The first part is the version of the apm-server and then -* is used to match all daily indices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended

_meta/beat.yml Outdated
@@ -230,7 +230,7 @@ apm-server:

#================================ Outputs =====================================

# Configure what output to use when sending the data collected by the beat.
# Configure what output to use when sending the data collected by the apm-server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another the removal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended

@@ -29,7 +29,7 @@ apm-server:
# Authorization token to be checked. If a token is set here the agents must
# send their token in the following format: Authorization: Bearer <secret-token>.
# It is recommended to use an authorization token in combination with SSL enabled,
# and save the token in the beats keystore.
# and save the token in the apm-server keystore.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this the is ok

@jalvz jalvz force-pushed the doc-clarifications branch from 063b982 to f09c58d Compare March 22, 2019 09:37
@jalvz jalvz force-pushed the doc-clarifications branch from f09c58d to 78c0e2b Compare March 22, 2019 09:44
@jalvz jalvz merged commit fa77a34 into elastic:master Mar 22, 2019
jalvz added a commit to jalvz/apm-server that referenced this pull request Mar 25, 2019
* setup with extra args doesn't setup pipelines

* remove some confusing beats references from apm-server.yml
jalvz added a commit to jalvz/apm-server that referenced this pull request Mar 25, 2019
* setup with extra args doesn't setup pipelines

* remove some confusing beats references from apm-server.yml
jalvz added a commit that referenced this pull request Mar 25, 2019
* setup with extra args doesn't setup pipelines

* remove some confusing beats references from apm-server.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect packaged readme
2 participants