Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] make update-beats-docs #1958

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Feb 25, 2019

Updating Beats documentation. Most of these are small grammar or formatting changes.

I'm curious about the new roles added in the table to the securing-beats.asciidoc page. Are these relevant to APM Server:

[options="header"]
|=======
|Feature | Role
|Send data to a secured cluster | ++{beat_default_index_prefix}_writer++ footnoteref:[noteA,These roles are user-defined.]
ifeval::["{beatname_lc}"=="filebeat"]
|Run Filebeat modules | ++{beat_default_index_prefix}_writer++ footnoteref:[noteA]
endif::[]
|Load index templates | ++{beat_default_index_prefix}_writer++ footnoteref:[noteA] and `kibana_user`
ifndef::no_dashboards[]
|Load {beatname_uc} dashboards into {kib} | ++{beat_default_index_prefix}_writer++ footnoteref:[noteA] and `kibana_user`
endif::[]
ifdef::has_ml_jobs[]
|Load machine learning jobs | `machine_learning_admin`
endif::[]
|Read indices created by {beatname_uc} | ++{beat_default_index_prefix}_reader++ footnoteref:[noteA]
ifndef::no_dashboards[]
|View {beatname_uc} dashboards in {kib} | `kibana_user`
endif::[]
ifdef::has_central_config[]
|Store and manage configurations in a central location in {kib} | `beats_admin`
endif::[]
ifndef::no_ilm[]
|Load index lifecycle policies and use index lifecycle management | +{beatname_lc}_ilm+ footnoteref:[noteA]
endif::[]
|=======
To create the user-defined roles shown here, see <<beats-basic-auth>> and
<<beats-user-access>>. You may want to define additional roles to provide more
restrictive access.

If someone could take a look when they have time, that'd be 🔥

I'd like to backport these to 7.0 (#1954) and 7.x (#1955)

@graphaelli
Copy link
Member

The _security url updates are 👍.

The "load dashboard" and "ilm" roles don't make sense for apm-server. The read indices is covered by the built-in apm_user role. The remaining entries, including the dashboard-viewing role, make sense to me me to keep.

@bmorelli25
Copy link
Member Author

bmorelli25 commented Feb 25, 2019

Great, thanks @graphaelli! We had almost everything correct then. I re-added View APM Server dashboards in Kibana, and changed Read indices created by APM Server to the new apm_user role. Here's what that page renders as now:


screen shot 2019-02-25 at 2 49 43 pm

@bmorelli25 bmorelli25 merged commit 72aad9e into elastic:master Feb 26, 2019
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Feb 26, 2019
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Feb 26, 2019
@bmorelli25 bmorelli25 deleted the feb/make-update-beats-docs branch February 26, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants