Specify minimal events on Intake API and ES level. #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add testfiles with minimal events on Intake API and run integration tests to create minimal ES documents. Some events have more than one minimal spec. fixes elastic#1812
|
Thanks, this is great! |
graphaelli
approved these changes
Feb 19, 2019
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Mar 12, 2019
Add testfiles with minimal events on Intake API and run integration tests to create minimal ES documents. Some events have more than one minimal spec. fixes elastic#1812
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Mar 12, 2019
Add testfiles with minimal events on Intake API and run integration tests to create minimal ES documents. Some events have more than one minimal spec. fixes elastic#1812
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Mar 12, 2019
Add testfiles with minimal events on Intake API and run integration tests to create minimal ES documents. Some events have more than one minimal spec. fixes elastic#1812
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Mar 12, 2019
Add testfiles with minimal events on Intake API and run integration tests to create minimal ES documents. Some events have more than one minimal spec. fixes elastic#1812
simitt
added a commit
that referenced
this pull request
Mar 12, 2019
simitt
added a commit
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testfiles with minimal events on Intake API and run integration tests to create minimal ES documents. Some events have more than one minimal spec.
fixes #1812
@elastic/apm-ui you could make use of how minimal events look like in your automated tests (as discussed with @sqren some time ago). Please be aware that there are some event types (error, span) that have multiple possibilities how a minimal event can look like. E.g. an error event either has a
logor anexceptionand if it has anexceptionthen it either has anexception.typeor anexception.message. All possibilities of how a minimal event can look like are covered with the examples.