rename span.hex_id to span.id #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
approved these changes
Jan 17, 2019
simitt
added a commit
to simitt/kibana
that referenced
this pull request
Jan 21, 2019
Rename `span.hex_id` and `transaction.span_count.dropped` related to elastic/apm-server#1809 related to elastic/apm-server#1811
simitt
added a commit
to elastic/kibana
that referenced
this pull request
Jan 21, 2019
Rename `span.hex_id` and `transaction.span_count.dropped` related to elastic/apm-server#1809 related to elastic/apm-server#1811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
span.idwas alongin 6.x, and only relevant to v1. Now it's a keyword, and has the valuespan.hex_idhad.Debate can continue in the issue (#1808) as to whether this is a good idea.
resolves #1808