Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.6] Remove ECS aliases #1795

Merged
merged 4 commits into from
Jan 16, 2019
Merged

[6.6] Remove ECS aliases #1795

merged 4 commits into from
Jan 16, 2019

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Jan 16, 2019

reverts most of #1609, part of #1670, and all of #1665.

aliases that remain are inherited from libbeat processors:

# Common Beats fields
- name: event.timezone
  path: beat.timezone

# Cloud processor fields
- name: cloud.provider
  path: meta.cloud.provider
- name: cloud.instance.id
  path: meta.cloud.instance_id
- name: cloud.instance.name
  path: meta.cloud.instance_name
- name: cloud.machine.type
  path: meta.cloud.machine_type
- name: cloud.availability_zone
  path: meta.cloud.availability_zone
- name: cloud.project.id
  path: meta.cloud.project_id
- name: cloud.region
  path: meta.cloud.region

# Docker processor fields
- name: container.id
  path: docker.container.id
- name: container.name
  path: docker.container.name
- name: container.image.name
  path: docker.container.image

closes #1794

will need a backport to 6.x

@simitt
Copy link
Contributor

simitt commented Jan 16, 2019

jenkins, retest this please

1 similar comment
@graphaelli
Copy link
Member Author

jenkins, retest this please

@graphaelli graphaelli added this to the 6.6 milestone Jan 16, 2019
- from: beat.hostname
to: host.hostname
alias6: true
alias: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we aliasing this field and not including it in the reindexing script? And shouldn't beat.hostname go to observer.hostname?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is confusing. This doesn't create an alias, it's just beats' log of their aliases. The only aliases that are actually created are listed in the description.

@graphaelli graphaelli merged commit d0067eb into elastic:6.6 Jan 16, 2019
@graphaelli graphaelli deleted the remove-aliases branch January 16, 2019 18:54
graphaelli added a commit to graphaelli/apm-server that referenced this pull request Jan 16, 2019
* remove APM ECS comptability aliases

* Revert "don't migrate beat.hostname"

This reverts commit 8d8b859.

* Revert "automate conflicting libbeat field removals (elastic#1665)"

This reverts commit 02a5147.

* revert fmt update
graphaelli added a commit that referenced this pull request Jan 17, 2019
* remove APM ECS comptability aliases

* Revert "don't migrate beat.hostname"

This reverts commit 8d8b859.

* Revert "automate conflicting libbeat field removals (#1665)"

This reverts commit 02a5147.

* revert fmt update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants