Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove kibana and dashboards #1715

Merged
merged 7 commits into from
Jan 18, 2019

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Dec 26, 2018

Removes Dashboards and Kibana from docs per #1673.

To do after merging:

  • Remove unused APM conditionals from the libbeat/docs/shared-kibana-config.asciidoc file to make life easier on the beats team

@bmorelli25 bmorelli25 added this to the 7.0 milestone Dec 26, 2018
@bmorelli25 bmorelli25 self-assigned this Dec 26, 2018
@bmorelli25 bmorelli25 requested a review from simitt December 26, 2018 21:12
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the dashboard and kibana section from the apm-server.yml file, the sections are currently marked as deprecated.

@bmorelli25
Copy link
Member Author

Thanks @simitt. I've updated apm-server.yml. I also removed a few references to dashboards/kibana in the elasticsearch output section.

@graphaelli
Copy link
Member

@bmorelli25 Can you update apm-server.docker.yml too please?

@bmorelli25
Copy link
Member Author

@graphaelli - apm-server.docker.yml has been updated

@bmorelli25
Copy link
Member Author

Just realized the apm-architecture.png image includes a reference to dashboards that we probably want to remove as well:
screen shot 2019-01-07 at 2 02 08 pm

Pinging @simitt / @formgeist (because of #198) -- Who created this image / How was it created / How can we update it?

@simitt
Copy link
Contributor

simitt commented Jan 8, 2019

Actually we still support dashboards, they are just not loaded via APM Server any more, but via Kibana. I think the visualisation is still fine.

@formgeist
Copy link
Contributor

@bmorelli25 I can update the diagram (and we should because new logos etc.), but it's used on the APM overview page that covers stuff beyond APM Server. Is it also shown in the APM Server docs?

@formgeist
Copy link
Contributor

Made some updates to the diagram #1739

@bmorelli25
Copy link
Member Author

@formgeist - it's only used in the APM Overview. The new image is perfect. Thanks for updating!

@bmorelli25 bmorelli25 force-pushed the remove-kibana-and-dashboards branch from 56daeac to ba7b1e5 Compare January 10, 2019 20:46
@bmorelli25
Copy link
Member Author

Rebased with #1634 changes. Added removed links to redirects.asciidoc. No longer blocked. OK to merge when you're ready for it @elastic/apm-server team!

@simitt
Copy link
Contributor

simitt commented Jan 11, 2019

@bmorelli25 I am sorry I overlooked that you made the changes directly in apm-server.yml. This is a generated file. You need to apply the changes in https://github.com/elastic/apm-server/blob/master/_meta/beat.yml. Running the command make update then generates the apm-server.yml. For the make command you need to have a proper python setup. Lmk if you run into any troubles and need help with the setup.

@bmorelli25
Copy link
Member Author

@simitt - Doh! Sorry about that. I was able to make the changes in _meta/beat.yml and run make update to generate the new apm-server.yml!

Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that @bmorelli25 !

@bmorelli25 bmorelli25 merged commit 8c39a87 into elastic:master Jan 18, 2019
@bmorelli25 bmorelli25 deleted the remove-kibana-and-dashboards branch January 18, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants