Surface config parsing error under EA managed mode (backport #14574) #14807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
By wrapping reloader errors in a way that EA manager understands (i.e. in a MultiError of UnitError), newRunner initialization errors, including config parsing errors, will be surfaced and logged. (cherry picked from commit 1b21d1d)
1 task
carsonip
approved these changes
Dec 3, 2024
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f48eb01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
By wrapping reloader errors in a way that EA manager understands (i.e. in a MultiError of UnitError), newRunner initialization errors, including config parsing errors, will be surfaced and logged.
Checklist
- [ ] Update CHANGELOG.asciidocI expect this to go into 8.17 first, then 8.16, but there may be uncertainty around this. We can add changelog before the release.How to test these changes
Start apm-server in EA managed mode (e.g. on ESS), pass in an invalid integration policy, e.g. setting
apm-server.rum.response_headersto a string instead of a list. Check that in fleet UI that EA input unit has failed. Check that an error is logged.Related issues
Fixes #14560
This is an automatic backport of pull request #14574 done by [Mergify](https://mergify.com).