Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing(cloud): remove missing Makefile target dep #14523

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

inge4pres
Copy link
Contributor

Motivation/summary

While investigating an issue, I found out a couple of problems in the testing setup.

How to test these changes

cd testing/cloud
make docker_image.auto.tfvars
make apply

Before this PR, this would throw an error on a missing dependency.

Then clean it up

make destroy

@inge4pres inge4pres added the test label Nov 4, 2024
@inge4pres inge4pres requested a review from a team as a code owner November 4, 2024 14:16
Copy link
Contributor

mergify bot commented Nov 4, 2024

This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Nov 4, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 4, 2024
@kruskall kruskall enabled auto-merge (squash) November 26, 2024 17:33
@kruskall kruskall merged commit 0baf868 into elastic:main Nov 26, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Nov 26, 2024
Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit 0baf868)
mergify bot added a commit that referenced this pull request Nov 26, 2024
Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit 0baf868)

Co-authored-by: Francesco Gualazzi <[email protected]>
v1v added a commit to v1v/apm-server that referenced this pull request Dec 3, 2024
…-with-main

* upstream/main: (100 commits)
  feat: bump beats to current main (elastic#14781)
  build(deps): bump github.com/elastic/elastic-agent-client/v7 from 7.16.0 to 7.17.0 (elastic#14757)
  PGO: Update default.pgo from benchmarks https://github.com/elastic/apm-server/actions/runs/12024199004/attempts/1. (elastic#14734)
  build(deps): bump slackapi/slack-github-action from 1.27.0 to 2.0.0 in the github-actions group (elastic#14656)
  build(deps): bump the otel group with 3 updates (elastic#14746)
  build(deps): bump the otel group across 1 directory with 4 updates (elastic#14681)
  testing: remove missing Make target dep (elastic#14523)
  build(deps): bump the dependencies group in /systemtest with 3 updates (elastic#14731)
  build(deps): bump chainguard/static in /packaging/docker (elastic#14732)
  build(deps): bump github.com/stretchr/testify from 1.9.0 to 1.10.0 (elastic#14733)
  chore: Update to elastic/beats@4278366ab032 (elastic#14725)
  changelog: add 8.15.5 entry (elastic#14720)
  chore: Update to elastic/beats@06ba17caf9ed (elastic#14711)
  Surface config parsing error under EA managed mode (elastic#14574)
  release-automation: update changelog template to add bug fixes section (elastic#14693)
  PGO: Update default.pgo from benchmarks https://github.com/elastic/apm-server/actions/runs/11946993444/attempts/1. (elastic#14699)
  changelog: add changelog entry for 8.16.1 (elastic#14690)
  chore: Update k8s stack yaml files (elastic#14686)
  docs: update release doc around documentation PR (elastic#14694)
  terraform: Use non-deprecated deployment template (elastic#14682)
  ...
v1v added a commit to v1v/apm-server that referenced this pull request Dec 3, 2024
* feature/support-8.x-with-main: (196 commits)
  support github label backport
  chore
  it should be main
  feat: bump beats to current main (elastic#14781)
  build(deps): bump github.com/elastic/elastic-agent-client/v7 from 7.16.0 to 7.17.0 (elastic#14757)
  PGO: Update default.pgo from benchmarks https://github.com/elastic/apm-server/actions/runs/12024199004/attempts/1. (elastic#14734)
  build(deps): bump slackapi/slack-github-action from 1.27.0 to 2.0.0 in the github-actions group (elastic#14656)
  build(deps): bump the otel group with 3 updates (elastic#14746)
  build(deps): bump the otel group across 1 directory with 4 updates (elastic#14681)
  testing: remove missing Make target dep (elastic#14523)
  build(deps): bump the dependencies group in /systemtest with 3 updates (elastic#14731)
  build(deps): bump chainguard/static in /packaging/docker (elastic#14732)
  build(deps): bump github.com/stretchr/testify from 1.9.0 to 1.10.0 (elastic#14733)
  chore: Update to elastic/beats@4278366ab032 (elastic#14725)
  changelog: add 8.15.5 entry (elastic#14720)
  chore: Update to elastic/beats@06ba17caf9ed (elastic#14711)
  Surface config parsing error under EA managed mode (elastic#14574)
  release-automation: update changelog template to add bug fixes section (elastic#14693)
  PGO: Update default.pgo from benchmarks https://github.com/elastic/apm-server/actions/runs/11946993444/attempts/1. (elastic#14699)
  changelog: add changelog entry for 8.16.1 (elastic#14690)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants