Add additional config remapping for "api_key" and "secret_token" for libbeat instrumentation wrapper #13691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libbeat instrumentation wrapper
axw
approved these changes
Jul 14, 2024
2 tasks
mergify bot
added a commit
that referenced
this pull request
Jul 15, 2024
… for libbeat instrumentation wrapper (#13691) (#13699) Add additional config remapping for "api_key" and "secret_token" for libbeat instrumentation wrapper. (cherry picked from commit 17fab5c) Co-authored-by: Kostiantyn Masliuk <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This PR addresses the issue by updating existing wrapper around libbeat instrumentation to additionally propagate erased tracer config keys "api_key" and "secret_token" from elastic agent via environmental variables.
Checklist
For functional changes, consider:
How to test these changes
Follow instructions in
Building an Elastic Agent container image with a locally built APM ServerandRunning an Elastic Agent container with a locally built APM Serversection inTESTING.md, update the relevantagent.monitoringsection with "api_key" or "secret_token" inelastic-agent.ymlto verify that tracing authentication works correctly.Related issues
#13690
#13597