Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for OTLP metrics partial success response #12276

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

endorama
Copy link
Member

@endorama endorama commented Dec 22, 2023

Motivation/summary

We recently introduced OTLP partial success response support in #11883. This PR adds a test case for OTLP metrics to ensure we are responding using a PartialSuccess.

Note that this test rely on triggering a partial response from the server by sending malformed Exponential Histogram data.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Run systemtests, verify that TestOTLPGRPCMetrics_partialSuccess passes.

Related issues

Ref: #12226

This change is needed to allow using exponential histograms in
other OTLP tests.
@endorama endorama requested a review from a team as a code owner December 22, 2023 12:08
Copy link
Contributor

mergify bot commented Dec 22, 2023

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 22, 2023
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@endorama endorama merged commit c0a9aeb into elastic:main Dec 22, 2023
11 checks passed
@endorama endorama deleted the otlp-partial-success-test branch December 22, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants