Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update APM server code for breaking changes in libbeat API (transport) #3416

Closed
ycombinator opened this issue Mar 3, 2020 · 2 comments · Fixed by #3418
Closed

Update APM server code for breaking changes in libbeat API (transport) #3416

ycombinator opened this issue Mar 3, 2020 · 2 comments · Fixed by #3418
Assignees
@axw

Comments

@ycombinator
Copy link
Contributor

ycombinator commented Mar 3, 2020 •
edited
Loading

We're undertaking some refactoring/cleanup in the libbeat codebase. One part of this is done by this PR: elastic/beats#16734.

Please see the "Developer Docs" section in the PR description for how it might impact APM server code. From my snooping around, it looks like the following locations might be impacted:
@ycombinator ycombinator mentioned this issue Mar 3, 2020
Merged
1 task
@graphaelli
Copy link
Member

Thanks for the heads up / opening this!

@ycombinator
Copy link
Contributor Author

Further heads up: we're about to merge elastic/beats#16734. It should happen some time today.

@ycombinator ycombinator changed the title Update APM server code for breaking changes in libbeat API Update APM server code for breaking changes in libbeat API (transport) Mar 5, 2020
@ycombinator ycombinator mentioned this issue Mar 6, 2020
Closed
@axw axw self-assigned this Mar 6, 2020
axw added a commit to axw/apm-server that referenced this issue Mar 6, 2020
@axw
Update beats framework to 9718fa246a26
0a56429 
Handle libbeat/common/transport moves.

Closes elastic#3416
axw added a commit to axw/apm-server that referenced this issue Mar 7, 2020
@axw
Update beats framework to 9718fa246a26
5f426c8 
Handle libbeat/common/transport moves.

Closes elastic#3416
@axw axw mentioned this issue Mar 7, 2020
Merged
4 tasks
axw added a commit to axw/apm-server that referenced this issue Mar 7, 2020
@axw
Update beats framework to 9718fa246a26
b3f8886 
Handle libbeat/common/transport moves.

Closes elastic#3416
@axw axw closed this as completed in #3418 Mar 10, 2020
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axw axw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to Go modules axw/apm-server
3 participants
@ycombinator @graphaelli @axw