Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch reading sourcemaps to use the official go-elasticsearch client #2868

Closed
simitt opened this issue Oct 29, 2019 · 1 comment
Closed

Comments

@simitt
Copy link
Contributor

simitt commented Oct 29, 2019

Since there is an official go-elasticsearch client, switch to use this library instead of the libbeat client for fetching the sourcemaps from ES.

@simitt simitt assigned simitt and unassigned simitt Oct 29, 2019
@simitt simitt self-assigned this Oct 29, 2019
@graphaelli graphaelli added this to the 7.6 milestone Nov 12, 2019
simitt added a commit to simitt/apm-server that referenced this issue Nov 13, 2019
Make use of newly integrated go-elasticsearch client for fetching
sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap
package and tests to get rid of some technical dept.

closes elastic#2868
simitt added a commit to simitt/apm-server that referenced this issue Nov 13, 2019
Make use of newly integrated go-elasticsearch client for fetching
sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap
package and tests to get rid of some technical dept.

closes elastic#2868
simitt added a commit to simitt/apm-server that referenced this issue Nov 13, 2019
Make use of newly integrated go-elasticsearch client for fetching
sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap
package and tests to get rid of some technical dept.

closes elastic#2868
simitt added a commit to simitt/apm-server that referenced this issue Nov 13, 2019
Make use of newly integrated go-elasticsearch client for fetching
sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap
package and tests to get rid of some technical dept.

closes elastic#2868
simitt added a commit to simitt/apm-server that referenced this issue Nov 13, 2019
Make use of newly integrated go-elasticsearch client for fetching
sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap
package and tests to get rid of some technical dept.

closes elastic#2868
simitt added a commit to simitt/apm-server that referenced this issue Nov 13, 2019
Make use of newly integrated go-elasticsearch client for fetching
sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap
package and tests to get rid of some technical dept.

closes elastic#2868
@simitt simitt closed this as completed in 498fe7e Nov 20, 2019
simitt added a commit to simitt/apm-server that referenced this issue Nov 20, 2019
Add the official go-elasticsearch client as dependency (v7.4.1), and use it
for fetching sourcemaps from Elasticsearch. Refactor current
sourcemap logic to get rid of some technical dept.

closes elastic#2868
simitt added a commit that referenced this issue Nov 21, 2019
Add the official go-elasticsearch client as dependency (v7.4.1), and use it
for fetching sourcemaps from Elasticsearch. Refactor current
sourcemap logic to get rid of some technical dept.

closes #2868
@axw axw assigned axw and unassigned simitt Jan 16, 2020
@axw
Copy link
Member

axw commented Jan 20, 2020

Verified that source mapping still works. I translated some basic CoffeeScript to JavaScript, and followed the instructions at https://www.elastic.co/guide/en/apm/server/current/sourcemap-api.html to upload. Caused the app to throw an exception, and verified the error in the UI showed up properly mapped.

There's an issue with privileges in apm-integration-testing: the apm_server role we create lacks the "read" privilege for "apm-*", so it can't query source maps. I tested with the admin user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants