-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch reading sourcemaps to use the official go-elasticsearch client #2868
Comments
Make use of newly integrated go-elasticsearch client for fetching sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap package and tests to get rid of some technical dept. closes elastic#2868
Make use of newly integrated go-elasticsearch client for fetching sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap package and tests to get rid of some technical dept. closes elastic#2868
Make use of newly integrated go-elasticsearch client for fetching sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap package and tests to get rid of some technical dept. closes elastic#2868
Make use of newly integrated go-elasticsearch client for fetching sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap package and tests to get rid of some technical dept. closes elastic#2868
Make use of newly integrated go-elasticsearch client for fetching sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap package and tests to get rid of some technical dept. closes elastic#2868
Make use of newly integrated go-elasticsearch client for fetching sourcemaps from Elasticsearch. While on it, refactor logic in sourcemap package and tests to get rid of some technical dept. closes elastic#2868
Add the official go-elasticsearch client as dependency (v7.4.1), and use it for fetching sourcemaps from Elasticsearch. Refactor current sourcemap logic to get rid of some technical dept. closes elastic#2868
Verified that source mapping still works. I translated some basic CoffeeScript to JavaScript, and followed the instructions at https://www.elastic.co/guide/en/apm/server/current/sourcemap-api.html to upload. Caused the app to throw an exception, and verified the error in the UI showed up properly mapped. There's an issue with privileges in apm-integration-testing: the |
Since there is an official go-elasticsearch client, switch to use this library instead of the libbeat client for fetching the sourcemaps from ES.
The text was updated successfully, but these errors were encountered: