Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rows_affected for database queries in spans #2802

Closed
3 tasks
simitt opened this issue Oct 16, 2019 · 1 comment · Fixed by #3095
Closed
3 tasks

Add rows_affected for database queries in spans #2802

simitt opened this issue Oct 16, 2019 · 1 comment · Fixed by #3095
Assignees
@axw
Labels
test-plan test-plan-ok v7.6.0
Milestone
7.6

Comments

@simitt
Copy link
Contributor

simitt commented Oct 16, 2019

  • Add span.context.db.rows_affected to Intake API as optional field
  • Clarify if field needs to be indexed.
  • Decide where to store the field in ES. There is an issue in ECS to standardize on sql fields.
@simitt simitt mentioned this issue Oct 16, 2019
Closed
@beniwohli beniwohli mentioned this issue Oct 24, 2019
Merged
@graphaelli graphaelli added this to the 7.6 milestone Oct 29, 2019
@simitt simitt self-assigned this Dec 31, 2019
simitt added a commit to simitt/apm-server that referenced this issue Dec 31, 2019
@simitt
intake: Add rows_affected to span db information
e8495a7 
Allow to include number of rows affected by a sql database statement
in the db information of a span.

closes elastic#2802
simitt added a commit to simitt/apm-server that referenced this issue Dec 31, 2019
@simitt
intake: Add rows_affected to span db information
cb20216 
Allow to include number of rows affected by a sql database statement
in the db information of a span.

closes elastic#2802
simitt added a commit to simitt/apm-server that referenced this issue Dec 31, 2019
@simitt
intake: Add rows_affected to span db information
14664e7 
Allow to include number of rows affected by a sql database statement
in the db information of a span.

closes elastic#2802
@simitt simitt mentioned this issue Dec 31, 2019
Merged
simitt added a commit that referenced this issue Jan 6, 2020
@simitt
intake: Add rows_affected to span db information (#3095)
2a032a1 
Allow to include number of rows affected by a sql database statement
in the db information of a span.

closes #2802
simitt added a commit to simitt/apm-server that referenced this issue Jan 6, 2020
@simitt
intake: Add rows_affected to span db information (elastic#3095)
26b1045 
Allow to include number of rows affected by a sql database statement
in the db information of a span.

closes elastic#2802
simitt added a commit to simitt/apm-server that referenced this issue Jan 6, 2020
@simitt
intake: Add rows_affected to span db information (elastic#3095)
7104395 
Allow to include number of rows affected by a sql database statement
in the db information of a span.

closes elastic#2802
simitt added a commit that referenced this issue Jan 7, 2020
@simitt
intake: Add rows_affected to span db information (#3095) (#3107)
4029166 
Allow to include number of rows affected by a sql database statement
in the db information of a span.

closes #2802
@axw axw assigned axw and unassigned simitt Jan 16, 2020
@axw
Copy link
Member

axw commented Jan 20, 2020

Confirmed this works with BC1, using Go agent v1.7.0:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axw axw

Labels
test-plan test-plan-ok v7.6.0
Projects
None yet
Milestone
7.6
Development

Successfully merging a pull request may close this issue.

intake: Add rows_affected to span db information simitt/apm-server
4 participants
@graphaelli @axw @mdelapenya @simitt