-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS: Set host.name along with host.hostname in exported data #2502
Comments
Related: elastic/ecs#498 (comment) |
We should probably set this in agents instead of in APM Server |
In what situation does cross-linking happen based on |
Everything except APM. In the Infra UI we have to put exceptions in for APM because they using Work Around Examples:
@elastic/beats @ruflin Any reason why we are not setting |
Linking to some context around discussions of |
Thanks for digging that up @simitt, I had forgotten some of that context. We can certainly copy
|
Use information from `system.name` when provided, otherwise derive data from `host.hostname`.` fixes elastic#2502
Use information from `system.name` when provided, otherwise derive data from `host.hostname`.` fixes elastic#2502
Use information from `system.name` when provided, otherwise derive data from `host.hostname`.` fixes #2502
Use information from `system.name` when provided, otherwise derive data from `host.hostname`.` fixes elastic#2502
Use information from `system.name` when provided, otherwise derive data from `host.hostname`.` fixes elastic#2502
Turns out agent collected information in Current behavior server side (after merging #2531 ):
We can change the behavior in the agents to send auto retrieved information in Other option would be to change behavior in the server to map I therefore suggest to change agent behavior and consider it a bug fix, as the customized information should have never ended up in the Suggested behavior:
cc @elastic/apm-agent-devs |
If the agents are updated to send the real hostname in |
Maybe we should leave existing |
Agree with @SergeyKleyman 's proposal. In case at least one of the two new fields are set, information in |
Deprecate existing `system.hostname` and add `system.detected_hostname` and `system.configured_hostname` to the Intake API. follow up on elastic#2502
I agree on leaving |
According to Elastic APM Backend Agent Config Comparison the name of the configuration option is |
Thanks, missed that somehow. I'd still prefer |
I don't think it's that important but the main reason I suggested more descriptive names is to make it clear that
Do you think the connection between Also I'm not sure how much of an optimization shortening What is the motivation for shorter names in Intake API if the Elasticsearch fields will be different anyway? Is it mostly to reduce network traffic volume? |
Yes, mostly that. Also (as you well know) more verbosity makes larger events which we need to split (per api_request_size) among more payloads. Agreed it's minor in this case. Also agreed with the rest of what you wrote. Only agent authors see the intake api so I can see making the field names make the most sense for that audience, and consider it a bonus when the persistence matches as well. |
IMO @graphaelli want to make a final call on the naming, so we can move on? |
I'm convinced, let's proceed as proposed, thanks. |
I created a dedicated issue for further discussions around |
Deprecate existing `system.hostname` and add `system.detected_hostname` and `system.configured_hostname` to the Intake API. follow up on #2502
Fixed by #2540 |
Deprecate existing `system.hostname` and add `system.detected_hostname` and `system.configured_hostname` to the Intake API. follow up on elastic#2502
APM server should be shipping
host.name
along withhost.hostname
per ECS.host.name
should default tohost.hostname
but allow the user to override it with their host identifier if it's different. This is necessary to ensure cross-linking between Infra UI and APM is consistent.The text was updated successfully, but these errors were encountered: