If no aborted then notify the pipeline syntax error (#1608)

* If no aborted then notify the pipeline syntax error * fix href and use quote format * Update resources/github-comment-markdown.template Co-authored-by: Mike Place <[email protected]> * Fix UT, remove assertion since the previous one does the same Co-authored-by: Mike Place <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
elastic · Mar 21, 2022 · 76e13a6 · 76e13a6
1 parent 63d86b4
commit 76e13a6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/resources/github-comment-markdown.template b/resources/github-comment-markdown.template
@@ -113,11 +113,11 @@ ${description}
   <%}%>
   </p>
   </details>
-<%} else {%>
+<%} else if (!buildStatus?.equals('ABORTED')) {%>
 ### Pipeline error [![1](https://img.shields.io/badge/1%20-red)](${env?.BUILD_URL}/console)
   <p>
-  This error is likely related to the pipeline itself. Please go to the traditional console output <a href=\"${env?.BUILD_URL}/console\">here</a>"
-  You will see the error (either a wrong syntax or configuration)
+  > This error is likely related to the pipeline itself. Click <a href="${env?.BUILD_URL}console">here</a>
+  > and then you will see the error (either incorrect syntax or an invalid configuration).
   </p>
 <%}%>
 <%}%>
diff --git a/src/test/groovy/NotificationManagerStepTests.groovy b/src/test/groovy/NotificationManagerStepTests.groovy
@@ -269,7 +269,6 @@ class NotificationManagerStepTests extends ApmBasePipelineTest {
     printCallStack()
     assertTrue(assertMethodCallContainsPattern('githubPrComment', 'Build Failed'))
     assertTrue(assertMethodCallContainsPattern('githubPrComment', 'Pipeline error'))
-    assertTrue(assertMethodCallContainsPattern('githubPrComment', 'go to the traditional console output'))
     assertJobStatusSuccess()
   }