-
Notifications
You must be signed in to change notification settings - Fork 68
add --apm-server-enable-data-streams option #1229
add --apm-server-enable-data-streams option #1229
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
@@ -917,6 +917,10 @@ def test_apm_server_custom_pipeline(self): | |||
self.assertIn("foo:/usr/share/apm-server/ingest/pipeline/definition.json", apm_server["volumes"]) | |||
self.assertIn("apm-server.register.ingest.pipeline.overwrite=true", apm_server["command"]) | |||
|
|||
def test_data_streams(self): | |||
apm_server = ApmServer(version="7.16.0", apm_server_enable_data_streams=True).render()["apm-server"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not allowing from 7.15
on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed any restriction on version number, this is just the one I picked for the test case.
Running {
"error": {
"root_cause": [
{
"type": "security_exception",
"reason": "unable to authenticate user [elastic] for REST request [/_index_template/traces-apm]",
"header": {
"WWW-Authenticate": [
"Basic realm=\"security\" charset=\"UTF-8\"",
"Bearer realm=\"security\"",
"ApiKey"
]
}
}
],
"type": "security_exception",
"reason": "unable to authenticate user [elastic] for REST request [/_index_template/traces-apm]",
"header": {
"WWW-Authenticate": [
"Basic realm=\"security\" charset=\"UTF-8\"",
"Bearer realm=\"security\"",
"ApiKey"
]
}
},
"status": 401
} Anything I'm missing? |
Hmm.. This might be a general problem on master caused by Kibana actually |
Yeah, #1232 opened for that |
That issue is resolved. Other things I've run into that are preventing this option from really working for now:
|
That last pipeline step is incorrect, that does actually work when you make sure it applies 🤦 . The next issue is:
This makes sense, we'll need a |
What does this PR do?
adds
--apm-server-enable-data-streams
option for instructing APM Server to write to data streams. This is valid in 7.16 and 8.0 (and maybe 7.15? it's not important to prevent it from being set in earlier versions)Related issues
related to elastic/apm-server#5949 - apm-server remains unhealthy until the integration is installed, not ideal but not blocked on that.