Add support for is_child in addition to elastic.is_child SpanLink attribute #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruskall
approved these changes
Jul 14, 2024
|
@kruskall you'll need to merge, because I don't have the merge permission on this repo |
This was referenced Jul 16, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185 added support for receiving inferred-span with our vendor-specific OpenTelemetry inferred-spans extension.
We recently contributed that extension upstream. In that process, we changed the SpanLink attribute for overriding parent-child relationships from
elastic.is_childto justis_child. Therefor, apm-server needs to support bothelastic.is_childandis_child.