Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix otlp database span resource #241

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Mar 11, 2024

With OTLP intake, the database spans always have their span.destination.service.resource set to {span.subtype}.

However when using our APM agents it's captured and sent as {span.subtype}/{db.name}, for example mysql/my-database.

This PR simply fixes the mapping for database spans.

Reported in our forum here.

The part where I'd like to have input from APM-server team is about the initial jaeger input which the tests refer to.

  • if a resource was already set (like in the jaeger test data), then this would potentially reduce the cardinality or at least change the current resource field value (so minor change visible in the map/dependencies).
  • if a resource was not already set, then this will just increase cardinality by a bit by providing some per-database cardinality.

@elastic-apm-tech elastic-apm-tech added the safe-to-test Changes are safe to run in the CI label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Changes are safe to run in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants