-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(benchmarks): memory allocation per function during page-load [s… #508
Conversation
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 93.87% 94.34% +0.47%
==========================================
Files 42 43 +1
Lines 1991 2245 +254
Branches 395 489 +94
==========================================
+ Hits 1869 2118 +249
- Misses 119 124 +5
Partials 3 3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vigneshshanmugam.
A general note, I think we should separate our build scripts for the final dist and the debugging and testing. Currently, it's hard to tell which function is used for what.
elastic#508) * chore(benchmarks): memory allocation per function during page-load [skip ci] * add diff bundle name for apm build [skip ci] * fix server start [skip ci] * address review comments [skip ci]
elastic#508) * chore(benchmarks): memory allocation per function during page-load [skip ci] * add diff bundle name for apm build [skip ci] * fix server start [skip ci] * address review comments [skip ci]
Adds some keys to the benchmark documents that matches with the function names that uses the most memory