Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(jenkins): benchmark in a bare metal #456

Merged
merged 10 commits into from
Oct 15, 2019
Merged

ci(jenkins): benchmark in a bare metal #456

merged 10 commits into from
Oct 15, 2019

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 11, 2019 •
edited
Loading

Highlights

  • When should match regex for tags.
  • Cleanup the workspace after the execution, ALWAYS
  • Required to pass the user to map the docker container user correctly.

@v1v v1v self-assigned this Oct 11, 2019
@v1v v1v added the automation label Oct 11, 2019
@v1v v1v added the ci label Oct 11, 2019
@v1v v1v marked this pull request as ready for review October 11, 2019 12:15
@hmdhk hmdhk mentioned this pull request Oct 11, 2019
Closed
12 tasks
vigneshshanmugam
vigneshshanmugam approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v1v for taking care of this feature 👍. I have linked to the relevant task in our issue.

@codecov-io
Copy link

codecov-io commented Oct 11, 2019 •
edited
Loading

Codecov Report

Merging #456 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #456      +/-   ##
=========================================
+ Coverage   94.04%   94.1%   +0.06%     
=========================================
  Files          40      40              
  Lines        2081    1882     -199     
  Branches      435     367      -68     
=========================================
- Hits         1957    1771     -186     
+ Misses        121     108      -13     
  Partials        3       3
Impacted Files Coverage Δ
...rum-core/src/performance-monitoring/transaction.js 96.51% <0%> (-1.09%) ⬇️
packages/rum-core/src/common/config-service.js 97.53% <0%> (-0.23%) ⬇️
packages/rum-core/src/common/utils.js 95.29% <0%> (-0.09%) ⬇️
packages/rum-core/src/common/apm-server.js 88.11% <0%> (-0.01%) ⬇️
packages/rum-core/src/common/constants.js 100% <0%> (ø) ⬆️
...s/rum-core/src/performance-monitoring/breakdown.js 97.87% <0%> (ø) ⬆️

@v1v
ci(jenkins): pass userid otherwise baremetal will have some leftovers…
3a4e455 
… as the deletedir doesn't work wehn the privileges are not correct
@v1v
Copy link
Member Author

v1v commented Oct 11, 2019

I'm blocked by the current permissions in the baremetal workspace as it cannot be deleted, waiting for the infra team to wipe it out, then I'll be able to test it with the new user_id changes.

@v1v
Copy link
Member Author

v1v commented Oct 14, 2019

jenkins run the tests please

@v1v v1v requested a review from vigneshshanmugam October 15, 2019 12:57
vigneshshanmugam
vigneshshanmugam approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v1v

@vigneshshanmugam vigneshshanmugam merged commit ee50b68 into elastic:master Oct 15, 2019
@v1v v1v deleted the fix/benchmark_delete branch October 15, 2019 17:14
David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
@v1v @vigneshshanmugam
ci(jenkins): benchmark in a bare metal (elastic#456)
a596cb4 
* ci(jenkins): benchmark running in a baremetal worker

* ci(jenkins): clean after the benchmark execution

* ci(jenkins): pass userid otherwise baremetal will have some leftovers as the deletedir doesn't work wehn the privileges are not correct

* as suggested let's fix the benchmarking

* Revert "as suggested let's fix the benchmarking"

This reverts commit 4c6e521.

* KISS: change the build as suggested

* Revert "Revert "as suggested let's fix the benchmarking""

This reverts commit 50afbca.

* run build on ci before benchmark script

* inherit exit codes from sub process

* exit only on errors otherwise continue
devcorpio pushed a commit to bmorelli25/apm-agent-rum-js that referenced this pull request Jan 25, 2022
@v1v @devcorpio
ci(jenkins): benchmark in a bare metal (elastic#456)
51328cd 
* ci(jenkins): benchmark running in a baremetal worker

* ci(jenkins): clean after the benchmark execution

* ci(jenkins): pass userid otherwise baremetal will have some leftovers as the deletedir doesn't work wehn the privileges are not correct

* as suggested let's fix the benchmarking

* Revert "as suggested let's fix the benchmarking"

This reverts commit 4c6e521.

* KISS: change the build as suggested

* Revert "Revert "as suggested let's fix the benchmarking""

This reverts commit 50afbca.

* run build on ci before benchmark script

* inherit exit codes from sub process

* exit only on errors otherwise continue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@mdelapenya mdelapenya Awaiting requested review from mdelapenya

Assignees

@v1v v1v

Labels
automation ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @codecov-io @vigneshshanmugam @kuisathaverat