Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use github secrets #1519

Merged
merged 1 commit into from
Aug 1, 2024
Merged

ci: use github secrets #1519

merged 1 commit into from
Aug 1, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 12, 2024

Similarly done in elastic/apm-agent-nodejs#4129 and elastic/elastic-otel-node#249

Remove the usage of Vault secrets for the NPMJS release

@v1v v1v requested review from a team July 12, 2024 12:53
@v1v v1v self-assigned this Jul 12, 2024
@v1v
Copy link
Member Author

v1v commented Aug 1, 2024

elastic/elastic-otel-node#249 was merged and https://github.com/elastic/elastic-otel-node/releases/tag/v0.3.0 has been published correctly.

We can merge now this PR.

@v1v v1v merged commit 51a9fb8 into elastic:main Aug 1, 2024
17 checks passed
@v1v v1v deleted the feature/remove-vault-totp branch August 1, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants