ci: run CDN if dist files #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devcorpio
changed the title
devcorpio
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
LGTM, thanks for doing this
Note: (same like this other PR)
just in case modify the feat(ci): to ci: before merging, I believe feat(ci) will affect the semantic versioning of our next release and we don't want these CI changes to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload artifacts only if artifacts exists. This should help with the corner case when one of the components in the mono-repo does not produce bundles.
as explained in https://github.com/orgs/community/discussions/25790 and google-github-actions/upload-cloud-storage#332