-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS specific instrumentations #1054
Merged
beniwohli
merged 12 commits into
elastic:master
from
beniwohli:aws-specific-instrumentations
Mar 23, 2021
Merged
AWS specific instrumentations #1054
beniwohli
merged 12 commits into
elastic:master
from
beniwohli:aws-specific-instrumentations
Mar 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: this will break current botocore tests. These will get fixed at a later point.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* add localstack setup for enhanced botocore tests * add specific instrumentation data for S3 note: this will break current botocore tests. These will get fixed at a later point. * use correct localstack URL * added support for SNS and DynamoDB * added some more testing for SNS and fixed an issue with default handlers * updated docs * add DB context fields to dynamodb * add WAIT_FOR config for localstack * don't use bridged network for localstack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
To better support AWS instrumentation, the current generic botocore instrumentation is enhanced to gather specific context data for a limited number of services.
The spec for these instrumentations: elastic/apm#415