Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS specific instrumentations #1054

Merged
merged 12 commits into from
Mar 23, 2021

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Feb 25, 2021

What does this pull request do?

To better support AWS instrumentation, the current generic botocore instrumentation is enhanced to gather specific context data for a limited number of services.

The spec for these instrumentations: elastic/apm#415

note: this will break current botocore tests. These will get fixed
at a later point.
@beniwohli beniwohli added this to the 7.12 milestone Feb 25, 2021
@beniwohli beniwohli self-assigned this Feb 25, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Feb 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1054 updated

  • Start Time: 2021-03-23T15:51:46.916+0000

  • Duration: 23 min 38 sec

  • Commit: 614799d

Test stats 🧪

Test Results
Failed 0
Passed 9718
Skipped 7614
Total 17332

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9718
Skipped 7614
Total 17332

@beniwohli beniwohli marked this pull request as ready for review March 23, 2021 18:06
@beniwohli beniwohli merged commit 3f4eddc into elastic:master Mar 23, 2021
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
* add localstack setup for enhanced botocore tests

* add specific instrumentation data for S3

note: this will break current botocore tests. These will get fixed
at a later point.

* use correct localstack URL

* added support for SNS and DynamoDB

* added some more testing for SNS and fixed an issue with default handlers

* updated docs

* add DB context fields to dynamodb

* add WAIT_FOR config for localstack

* don't use bridged network for localstack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants