fix errors in pymongo tests introduced in #1639 (#1648)

* fix errors in pymongo tests introduced in #1639 * fix cursor refresh destination tracking
elastic · Oct 3, 2022 · 5447d49 · 5447d49
1 parent 21980d8
commit 5447d49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/elasticapm/instrumentation/packages/pymongo.py b/elasticapm/instrumentation/packages/pymongo.py
@@ -132,7 +132,8 @@ def call(self, module, method, wrapped, instance, args, kwargs):
             span_type="db",
             span_subtype="mongodb",
             span_action="query",
-            extra={"destination": {}},
+            extra=context,
+            leaf=True,
         ) as span:
             response = wrapped(*args, **kwargs)
             if span.context and instance.address:

diff --git a/tests/instrumentation/pymongo_tests.py b/tests/instrumentation/pymongo_tests.py
@@ -99,7 +99,7 @@ def test_collection_count(instrument, elasticapm_client, mongo_database):
     assert span["context"]["destination"] == {
         "address": os.environ.get("MONGODB_HOST", "localhost"),
         "port": int(os.environ.get("MONGODB_PORT", 27017)),
-        "service": {"name": "", "resource": "mongodb", "type": ""},
+        "service": {"name": "", "resource": "mongodb/elasticapm_test", "type": ""},
     }
 
 
@@ -258,7 +258,7 @@ def test_collection_find(instrument, elasticapm_client, mongo_database):
         assert span["context"]["destination"] == {
             "address": os.environ.get("MONGODB_HOST", "localhost"),
             "port": int(os.environ.get("MONGODB_PORT", 27017)),
-            "service": {"name": "", "resource/elasticapm_test": "mongodb", "type": ""},
+            "service": {"name": "", "resource": "mongodb/elasticapm_test", "type": ""},
         }