Implement initial public API #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ezimuel I've made the changes that we discussed - please take look. |
|
@SergeyKleyman let me know when you finish to push code, otherwise I cannot start the review. Thanks! |
Sorry - I finished, please go ahead and start the review. |
ezimuel
reviewed
Feb 24, 2020
There was a problem hiding this comment.
I just commented few points. Overall, the approach is very good but sometime I feel a little bit Over-engineered. Even, the idea of Impl classes and usage of @internal it's not that appealing to me. Anyway, I think we can discuss more on our next meeting. That said, nice work anyway!
|
@ezimuel I've made all the changes we discussed - please take a look. |
|
@SergeyKleyman LGTM! |
This was referenced Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.