Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: remove snapshoty #4057

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 4, 2024

We are not using it, let's remove it

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@v1v v1v requested a review from a team June 4, 2024 15:35
@v1v v1v self-assigned this Jun 4, 2024
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please also remove this from package.json:

package.json
32:    "package:snapshot": "rm -rf ./build/snapshot && mkdir -p ./build/snapshot && npm pack --pack-destination ./build/snapshot"

@v1v
Copy link
Member Author

v1v commented Jun 4, 2024

Let's please also remove this from package.json:

Is it unrelated to the snapshoty?

@trentm
Copy link
Member

trentm commented Jun 4, 2024

Is it unrelated to the snapshoty?

No. It is/was only there to support the "snapshoty" CI workflow (both added in #3050).

@v1v v1v requested a review from trentm June 4, 2024 16:19
@v1v v1v merged commit 24246bf into elastic:main Jun 4, 2024
17 checks passed
@v1v v1v deleted the feature/remove-snapshoty branch June 4, 2024 18:45
trentm pushed a commit that referenced this pull request Jun 5, 2024
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants