-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix tests to work with restify@9 #3031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restify@9 was recently released. It only works with node >=v14.18.0 because it added use of https://nodejs.org/api/modules.html#core-modules This updates restify testing to skip out when there is an incompat (restify, node) version pair. Note: It looks like the intent may have been for restify@9 to support node >=10.0.0, so this may be refined later.
github-actions
bot
added
the
agent-nodejs
Make available for APM Agents project planning.
label
Nov 17, 2022
I've opened restify/node-restify#1932 about the "engines" mismatch. |
…et's improve the debugging output
run module tests for restify |
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
restify@9 was recently released. It only works with node >=v14.18.0 because it added use of https://nodejs.org/api/modules.html#core-modules This updates restify testing to skip out when there is an incompat (restify, node) version pair. Also an unrelated change in "http-run-context.test.js" to get better debug output if a spurious error is hit in it again.
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
elastic#3033) This is a follow-on to elastic#3031 to handle testing of Node.js nightly builds. These have a prerelease version, e.g. "v20.0.0-nightly202211186f9175deaa", and therefore need the includePrelease semver option for gte comparison. Refs: elastic#3031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restify@9 was recently released. It only works with node >=v14.18.0
because it added use of https://nodejs.org/api/modules.html#core-modules
This updates restify testing to skip out when there is an incompat
(restify, node) version pair.
Note: It looks like the intent may have been for restify@9 to support
node >=10.0.0, so this may be refined later.
In this TAV CI test run the restify tests broke for node v8, v10, v12. Fine for node v14.
https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/main/496/pipeline
The breakage is in this restify file:
The "node:" prefix is called "Core modules" (https://nodejs.org/api/modules.html#core-modules). This was added in v16.0.0, v14.18.0.
Restify@9's package.json says
"engines": { "node": ">=10.0.0" }
so the intent might have been to support node v10. I'll open an issue on restify asking about that.