Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add some context to test failure to help with debugging it #2647

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Apr 19, 2022

A tweak to get some details if this test (sensitive to timing) fails again in CI.

There was a recent failure of this test in GH Actions CI: https://github.com/elastic/apm-agent-nodejs/runs/6081847063?check_suite_focus=true#step:8:2934
It might be helpful to know if span.composite.sum was exactly 30 for that failure, or less, to know how to best make this test less flaky.

@trentm trentm requested a review from astorm April 19, 2022 18:03
@trentm trentm self-assigned this Apr 19, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Apr 19, 2022
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-19T18:03:28.575+0000

  • Duration: 27 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 244817
Skipped 0
Total 244817

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit 0073f1d into main Apr 19, 2022
@trentm trentm deleted the trentm/add-test-case-details branch April 19, 2022 20:49
trentm added a commit that referenced this pull request Apr 21, 2022
These two 'span.composite.sum > 30' tests have been flaky in CI. A recent
failure shows a value of `29.699`. The theory is that this is due to
the setTimeout calls firing slightly sooner than 10ms as discussed at:
nodejs/node#26578 (comment)

Refs: #2647
trentm added a commit that referenced this pull request Apr 25, 2022
These two 'span.composite.sum > 30' tests have been flaky in CI. A recent
failure shows a value of `29.699`. The theory is that this is due to
the setTimeout calls firing slightly sooner than 10ms as discussed at:
nodejs/node#26578 (comment)

Refs: #2647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants