-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recycle via reference counting #587
Conversation
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
============================================
- Coverage 63.7% 63.34% -0.37%
Complexity 68 68
============================================
Files 189 189
Lines 7431 7428 -3
Branches 871 861 -10
============================================
- Hits 4734 4705 -29
- Misses 2433 2444 +11
- Partials 264 279 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a big PR already, but can we also lose TraceContextHolder
and restore the simpler Span hierarchy now, or do we still need it?
If it's ended before the child starts it is still not recycled because the reference count is not at zero yet.