Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS/400 avoids using NOFOLLOW_LINKS #3905

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

LikeTheSalad
Copy link
Contributor

@LikeTheSalad LikeTheSalad commented Dec 5, 2024

What does this PR do?

Skips using NOFOLLOW_LINKS file open option when running on OS/400.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@LikeTheSalad LikeTheSalad requested a review from a team December 5, 2024 12:31
@jackshirazi
Copy link
Contributor

looks good. Add a changelog entry and we just need user confirmation it works

@LikeTheSalad LikeTheSalad linked an issue Dec 5, 2024 that may be closed by this pull request
@LikeTheSalad
Copy link
Contributor Author

User has just confirmed it works, so if there are no further actions needed here I think I'll merge it later today.

@LikeTheSalad LikeTheSalad merged commit 807b20b into elastic:main Dec 12, 2024
14 checks passed
@LikeTheSalad LikeTheSalad deleted the os-400-no-follow-links branch December 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NOFOLLOW_LINKS causes issues on IBM OS/400
2 participants