Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate specs update to updatecli #3053

Merged

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Mar 9, 2023

What

Migrate https://github.com/elastic/apm/blob/main/.ci/Jenkinsfile to the consumer using updatecli and GH Actions workflows.

Why

Jenkins 2 GH Actions Migration

How to test

export GITHUB_TOKEN="$(gh auth token)"
export GIT_USER="FooBar"
export GIT_EMAIL="[email protected]"
updatecli --config .ci/update-json-specs.yml diff
updatecli --config .ci/update-gherkin-specs.yml diff

@reakaleek reakaleek self-assigned this Mar 9, 2023
@reakaleek reakaleek requested a review from a team March 9, 2023 14:07
@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

👋 @reakaleek Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@reakaleek reakaleek requested a review from a team March 9, 2023 14:08
@apmmachine
Copy link
Contributor

apmmachine commented Mar 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T09:34:16.993+0000

  • Duration: 57 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 3569
Skipped 121
Total 3690

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

draft: false
labels:
- "automation"
description: |-
Copy link
Member

@v1v v1v Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think adding the title field so the name of the PR is something handled also here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,115 @@
name: update-gherkin-specs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we could use the proposal for updatecli.d to benefit from the vscode integration:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -11,19 +11,34 @@ permissions:
jobs:
bump:
runs-on: ubuntu-latest
strategy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use a folder instead:

Then there is no need for a matrix job.

Though, if one of them failed I don't know how this will be behave

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it with diff

Run Summary
===========
Pipeline(s) run:
  * Changed:    1
  * Failed:     0
  * Skipped:    0
  * Succeeded:  2
  * Total:      3

looking at the summary, I assume succesful pipeline won't be affected by failing ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for double checking this!

@JonasKunz JonasKunz removed community Issues and PRs created by the community triage labels Mar 21, 2023
Copy link
Contributor

@JonasKunz JonasKunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the failing tests: Those were already fixed on main, so you should be good to merge after rebasing/merging the current main into this PR.

@reakaleek reakaleek force-pushed the feature/migrate-specs-update-to-updatecli branch from 3c1b130 to 590107a Compare March 21, 2023 09:33
@reakaleek reakaleek enabled auto-merge (squash) March 21, 2023 09:34
@reakaleek reakaleek merged commit cbfaa04 into elastic:main Mar 21, 2023
@reakaleek reakaleek deleted the feature/migrate-specs-update-to-updatecli branch March 21, 2023 10:55
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants