Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maven search links #3045

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Update maven search links #3045

merged 1 commit into from
Mar 6, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Mar 6, 2023 •
edited
Loading

What does this PR do?

Opening links to search.maven.org with a browser will show the a popup with the following message:

On February 23, 2023, we started redirecting users from search.maven.org to central.sonatype.com. Launched in September of 2022, central.sonatype.com provides the main functionality of search.maven.org with enhanced search results, including security vulnerability and software quality information.

This PR updates all the links we have to search.maven.org to use central.sonatype.com.

Checklist

  • This is something else

@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-06T10:18:21.448+0000

  • Duration: 4 min 56 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge marked this pull request as ready for review March 6, 2023 11:35
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

/test

@SylvainJuge SylvainJuge requested a review from jackshirazi March 6, 2023 11:38
@SylvainJuge SylvainJuge merged commit b242cc6 into elastic:main Mar 6, 2023
@SylvainJuge SylvainJuge deleted the mvn-search-link branch March 6, 2023 14:11
@SylvainJuge SylvainJuge mentioned this pull request Mar 10, 2023
Merged
1 task
SylvainJuge added a commit to elastic/kibana that referenced this pull request Mar 20, 2023
@SylvainJuge
Fix javaagent download link (#153086)
7d3f78c 
## Summary

The URL we provide to download the Java agent from maven central is not
working as it used to.
This is exactly the same issue that was solved here:
elastic/apm-agent-java#3045 for more details.


### Checklist

This is just changing an URL in APM agent setup instructions

### Risk Matrix
This is just changing an URL in APM agent setup instructions, thus very
low risk

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 20, 2023
@SylvainJuge
Fix javaagent download link (elastic#153086)
fa9fd97 
## Summary

The URL we provide to download the Java agent from maven central is not
working as it used to.
This is exactly the same issue that was solved here:
elastic/apm-agent-java#3045 for more details.

### Checklist

This is just changing an URL in APM agent setup instructions

### Risk Matrix
This is just changing an URL in APM agent setup instructions, thus very
low risk

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 7d3f78c)
kibanamachine added a commit to elastic/kibana that referenced this pull request Mar 20, 2023
@kibanamachine @SylvainJuge
[8.7] Fix javaagent download link (#153086) (#153291)
db7a111 
# Backport

This will backport the following commits from `main` to `8.7`:
- [Fix javaagent download link
(#153086)](#153086)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"SylvainJuge","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-20T12:07:34Z","message":"Fix
javaagent download link (#153086)\n\n## Summary\r\n\r\nThe URL we
provide to download the Java agent from maven central is not\r\nworking
as it used to.\r\nThis is exactly the same issue that was solved
here:\r\nhttps://github.com/elastic/apm-agent-java/pull/3045 for more
details.\r\n\r\n\r\n### Checklist\r\n\r\nThis is just changing an URL in
APM agent setup instructions\r\n\r\n### Risk Matrix\r\nThis is just
changing an URL in APM agent setup instructions, thus very\r\nlow
risk\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7d3f78c81f2bf7ea6fedd53c547c9431f1c2c462","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","v8.7.0","v8.8.0"],"number":153086,"url":"https://github.com/elastic/kibana/pull/153086","mergeCommit":{"message":"Fix
javaagent download link (#153086)\n\n## Summary\r\n\r\nThe URL we
provide to download the Java agent from maven central is not\r\nworking
as it used to.\r\nThis is exactly the same issue that was solved
here:\r\nhttps://github.com/elastic/apm-agent-java/pull/3045 for more
details.\r\n\r\n\r\n### Checklist\r\n\r\nThis is just changing an URL in
APM agent setup instructions\r\n\r\n### Risk Matrix\r\nThis is just
changing an URL in APM agent setup instructions, thus very\r\nlow
risk\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7d3f78c81f2bf7ea6fedd53c547c9431f1c2c462"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153086","number":153086,"mergeCommit":{"message":"Fix
javaagent download link (#153086)\n\n## Summary\r\n\r\nThe URL we
provide to download the Java agent from maven central is not\r\nworking
as it used to.\r\nThis is exactly the same issue that was solved
here:\r\nhttps://github.com/elastic/apm-agent-java/pull/3045 for more
details.\r\n\r\n\r\n### Checklist\r\n\r\nThis is just changing an URL in
APM agent setup instructions\r\n\r\n### Risk Matrix\r\nThis is just
changing an URL in APM agent setup instructions, thus very\r\nlow
risk\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7d3f78c81f2bf7ea6fedd53c547c9431f1c2c462"}}]}]
BACKPORT-->

Co-authored-by: SylvainJuge <[email protected]>
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackshirazi jackshirazi jackshirazi approved these changes

Assignees
No one assigned
Labels
agent-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SylvainJuge @apmmachine @jackshirazi