Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump org.apache.logging.log4j:log4j-core to 2.20.0 #3033

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

candrews
Copy link
Contributor

What does this PR do?

Update the org.apache.logging.log4j:log4j-core dependency in apm-agent-plugins/apm-ecs-logging-plugin/pom.xml to the current latest version, 2.20.0

2.14.1 is vulnerable to CVE-2021-44228.

I know this dependency is of scope provided meaning it won't actually be included in the agent artifact jar, but the fact that there is a vulnerable dependency in the dependency graph at all (even if it isn't used and doesn't actually matter) isn't great, and definitely upsets some security folks.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 22, 2023

💚 CLA has been signed

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Feb 22, 2023
@github-actions
Copy link

👋 @candrews Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@apmmachine
Copy link
Contributor

apmmachine commented Feb 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-02-23T07:49:11.172+0000

  • Duration: 53 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 3530
Skipped 121
Total 3651

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@eyalkoren
Copy link
Contributor

/test

@eyalkoren
Copy link
Contributor

@candrews please note that I will not be able to merge this PR without you signing the CLA.
So please either sign it or let me know if you want me to make this change through a different PR.

@candrews
Copy link
Contributor Author

I signed the CLA - do I need to do something to get that reflected in this PR?

@eyalkoren
Copy link
Contributor

I signed the CLA - do I need to do something to get that reflected in this PR?

No, we're good!

@eyalkoren
Copy link
Contributor

run elasticsearch-ci/docs

@eyalkoren eyalkoren merged commit 5a956a1 into elastic:main Feb 23, 2023
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants