Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnest exceptions before filtering #3025

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Unnest exceptions before filtering #3025

merged 5 commits into from
Feb 21, 2023

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Feb 20, 2023 •
edited
Loading

What does this PR do?

Fixes an issue reported in our forum- when nested exceptions get unnested, they will be reported even if they are of type that matches the configured ignore_exceptions.

Checklist

  • This is a bugfix

@eyalkoren eyalkoren added the bug Bugs label Feb 20, 2023
@apmmachine
Copy link
Contributor

apmmachine commented Feb 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-02-21T08:58:00.808+0000

  • Duration: 55 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 3524
Skipped 121
Total 3645

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

jackshirazi
jackshirazi approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@jackshirazi jackshirazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@eyalkoren eyalkoren merged commit 44ed8c2 into elastic:main Feb 21, 2023
@eyalkoren eyalkoren deleted the unnest-exceptions-before-filtering branch February 21, 2023 12:40
markush81 added a commit to markush81/apm-agent-java that referenced this pull request Feb 23, 2023
@markush81
Merge branch 'main' into apm-agent-java/issues/2976
101cd83 
* main:
  make the Agent.activationMethod field immutable (elastic#3032)
  Add Activation method for telemetry on how the agent was started (elastic#2926)
  Unnest exceptions before filtering (elastic#3025)
  Use composite action for updatecli workflow (elastic#3023)

# Conflicts:
#	CHANGELOG.asciidoc
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackshirazi jackshirazi jackshirazi approved these changes

Assignees
No one assigned
Labels
agent-java bug Bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyalkoren @apmmachine @jackshirazi