Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-specs updatecli workflow #3012

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 8, 2023

What does this pull request do?

Moves the update specs workflow from apm-server to the consumer using updatecli to have a "dependabot"-like experience.

As a replacement for created PRs like: #2938

How to test

GITHUB_TOKEN=<token>\
GIT_USER=<username> \
GIT_EMAIL=j<email> \
updatecli diff -c .ci/update-specs.yml

Related issues

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

👋 @reakaleek Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@reakaleek reakaleek requested review from a team February 8, 2023 13:49
@reakaleek reakaleek self-assigned this Feb 8, 2023
@reakaleek reakaleek marked this pull request as ready for review February 8, 2023 13:49
@apmmachine
Copy link
Contributor

apmmachine commented Feb 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-02-09T18:39:17.249+0000

  • Duration: 59 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 3518
Skipped 121
Total 3639

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a way to judge it with my current knowledge, but you feeling confident about it is so good enough for me.
What I don't get is what triggers the creation of the PR. What "a dependabot-like experience" means? Is it based on existing vs. latest artifact versions somehow?

@reakaleek
Copy link
Member Author

reakaleek commented Feb 13, 2023

Hi @eyalkoren,

actually, it's just a cron trigger. Updatecli determines itself if there is a change or not. Dependening on the outcome it creates a PR or not.

@reakaleek reakaleek merged commit ea3105d into elastic:main Feb 13, 2023
@reakaleek reakaleek deleted the feature/add-update-specs-action branch February 13, 2023 08:12
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants