Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip deploying of java 17 subprojects #2998

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

JonasKunz
Copy link
Contributor

What does this PR do?

During the last release I noticed that our release job attempts to deploy the new java 17-specific subprojects aswell, which is not intentional to my knowledge.

Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, because it is a top level subproject we need to say that explicitly?
LGTM

@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-01-31T14:48:07.717+0000

  • Duration: 56 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 3446
Skipped 43
Total 3489

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JonasKunz
Copy link
Contributor Author

Ahh, because it is a top level subproject we need to say that explicitly? LGTM

Exactly. The plugin projects for example do not need to specify it because they inherit the settings from their apm-agent-plugins (potentially transitive) parent, where the maven-deploy-plugin.skip is set to true.

@JonasKunz JonasKunz merged commit 1cc683e into elastic:main Jan 31, 2023
@JonasKunz JonasKunz deleted the skip_deploy_java17 branch January 31, 2023 15:46
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants