-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS SDK instrumentation for S3 and DynamoDB #2606
Conversation
@Nullable | ||
private static DynamoDbHelper INSTANCE; | ||
|
||
public static DynamoDbHelper getInstance() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although unlikely, there could be concurrent calls that would create multiple instances, which could produce different threads using different req-table maps. This would quickly be resolved for subsequent requests, so it is only a matter of some odd initial reqs being handled incorrectly in the worst case. So can leave it like this, especially if the lazy initialization is deliberate. An alternative is to initialize at class initialization time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the lazy initialization is good to not allocate unnecessary memory in case certain parts of the SDK are not used at all (e.g. S3 but not DynamoDB).
Regarding race, I agree that it's possible but very unlikely and also not a big problem when it occurs. And actually we do the same in other plugins already. I think introducing a synchronized block is not worth the benefit compared to the performance impact. So I would leave it as is.
...s-sdk/apm-aws-sdk-1-plugin/src/main/java/co/elastic/apm/agent/awssdk/v1/helper/S3Helper.java
Show resolved
Hide resolved
...k-1-plugin/src/main/java/co/elastic/apm/agent/awssdk/v1/AmazonHttpClientInstrumentation.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
* AWS SDK instrumentation for S3 and DynamoDB * fixed Java 7 compatibility problems * added license headers * refactored test to use Java 8 Collection utils * Update configuration.asciidoc * refactored abstract test class for aws sdk * Update CHANGELOG.asciidoc to add S3 and DynamoDB
What does this PR do?
Instrumentation for AWS SDK covering S3 and DynamoDB
Closes #1636
Closes #1637
Checklist