Add http url to span context #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
============================================
+ Coverage 73.52% 73.66% +0.13%
- Complexity 1112 1125 +13
============================================
Files 117 118 +1
Lines 4193 4218 +25
Branches 412 416 +4
============================================
+ Hits 3083 3107 +24
- Misses 911 912 +1
Partials 199 199
Continue to review full report at Codecov.
|
felixbarny
reviewed
Sep 20, 2018
| @@ -56,7 +56,7 @@ private static void onBeforeExecute(@Advice.Argument(0) HttpRoute route, | |||
| return; | |||
| } | |||
| final AbstractSpan<?> parent = tracer.getActive(); | |||
| span = HttpClientHelper.startHttpClientSpan(parent, request.getMethod(), route.getTargetHost().getHostName(), SPAN_TYPE_APACHE_HTTP_CLIENT); | |||
| span = HttpClientHelper.startHttpClientSpan(parent, request.getMethod(), String.valueOf(request.getURI()), route.getTargetHost().getHostName(), SPAN_TYPE_APACHE_HTTP_CLIENT); | |||
There was a problem hiding this comment.
why do you use String.valueOf here? Can the URI return null? In that case, it might be better to change the signature of startHttpClientSpan to @Nullable URI or @Nullable String and only set if not null.
There was a problem hiding this comment.
According to HttpRequestWrapper's constructor it can be set to null. You're right, better not to set a null string.
felixbarny
approved these changes
Sep 20, 2018
felixbarny
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.