Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to Statement.getUpdateCount #1147

Merged
merged 4 commits into from
Apr 20, 2020

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Apr 20, 2020

Due to many issues and unexpected side-effects of calling Statement.getUpdateCount, we decided to remove calls to this method performed by our agent.

This will partially revert work that has been done for elastic/apm#112 / #707

Here is the non-exhaustive list of issues/PR that are related to this simple (but cursed) feature:

This will be a two-step process

  • quickly remove calls to getUpdateCount from the agent
  • properly proceed to removal, and make sure that feature is still supported for Statement.executeUpdate(), for which we can capture the return value.

@SylvainJuge SylvainJuge self-assigned this Apr 20, 2020
@SylvainJuge SylvainJuge merged commit 5f3a4f9 into elastic:master Apr 20, 2020
@SylvainJuge SylvainJuge deleted the try-disable-getUpdateCount branch April 20, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants