Remove calls to Statement.getUpdateCount #1147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to many issues and unexpected side-effects of calling
Statement.getUpdateCount
, we decided to remove calls to this method performed by our agent.This will partially revert work that has been done for elastic/apm#112 / #707
Here is the non-exhaustive list of issues/PR that are related to this simple (but cursed) feature:
getUpdateCount
is not supported by all drivers and might throwSQLException
This will be a two-step process
getUpdateCount
from the agentStatement.executeUpdate()
, for which we can capture the return value.