-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate IGNORE_URLS and replace with TRANSACTION_IGNORE_URLS #811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Seems that there's a CI issue caused by some changes to gorm... looking into it
| Environment | Default | Example | ||
| `ELASTIC_APM_IGNORE_URLS` | | `/heartbeat*, *.jpg` | ||
| Environment | Default | Example | ||
| `ELASTIC_APM_TRANSACTION_IGNORE_URLS` | | `/heartbeat*, *.jpg` | ||
|============ | ||
|
||
A list of patterns to match HTTP requests to ignore. An incoming HTTP request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a note below that we'll continue to support "ELASTIC_APM_IGNORE_URLS", and that it's deprecated and will be removed in a future release
Ah there's also a formatting issue - please run |
Co-authored-by: Andrew Wilkins <[email protected]>
@jalvz sorry, I forgot to mention earlier: the gorm CI failure is fixed on master - please merge master into the PR. |
…go into ignore-transaction-urls
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 84.67% 84.65% -0.02%
==========================================
Files 130 130
Lines 8472 8474 +2
==========================================
Hits 7174 7174
- Misses 911 912 +1
- Partials 387 388 +1
Continue to review full report at Codecov.
|
Closes #792