Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmot: follows-from is not supported #414

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

axw
Copy link
Member

@axw axw commented Jan 8, 2019

Bring the code in line with the docs, and do not support follows-from.

Fixes #413

Bring the code in line with the docs, and do
not support follows-from.
@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #414 into master will increase coverage by 3.24%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #414      +/-   ##
=========================================
+ Coverage   80.66%   83.9%   +3.24%     
=========================================
  Files         102     102              
  Lines        6148    6151       +3     
=========================================
+ Hits         4959    5161     +202     
- Misses        915     919       +4     
+ Partials      274      71     -203
Impacted Files Coverage Δ
module/apmot/context.go 80% <86.66%> (-6.96%) ⬇️
transport/transporttest/recorder.go 82.19% <0%> (ø) ⬆️
modelwriter.go 95.04% <0%> (+0.82%) ⬆️
internal/radix/radix.go 39.92% <0%> (+0.92%) ⬆️
utils.go 80.68% <0%> (+1.13%) ⬆️
internal/sqlscanner/scanner.go 96.82% <0%> (+1.58%) ⬆️
metrics.go 91.66% <0%> (+1.66%) ⬆️
context.go 94.05% <0%> (+1.98%) ⬆️
internal/apmhttputil/url.go 97.87% <0%> (+2.12%) ⬆️
module/apmsql/stmt.go 63.82% <0%> (+2.12%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e510527...cbe7eee. Read the comment docs.

@axw axw merged commit e6ec793 into elastic:master Jan 8, 2019
@axw axw deleted the apmot-no-follows-from branch January 8, 2019 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants